Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deployment output files to the image during build #186

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Feb 1, 2024

The image-building process includes several smart contract deployments. Deployed smart contracts have specific addresses that are stored in "docker/deploymentOutput" directory. Meaning each specific image has its own smart contract addresses that should be known by users of this image. Curently, these addresses are not stored anywhere so most likely we lose them and have to create a new image again.

The idea is to include the output file with the addresses of all smart contracts that were deployed during the build of this image into the image and make them accessible via http endpoint.

  • Added deployment files to the image during build
  • Serve deployment files via nginx on 9545 port

@cla-bot cla-bot bot added the cla-signed label Feb 1, 2024
@begmaroman begmaroman changed the base branch from main to develop February 1, 2024 14:51
Copy link

cla-bot bot commented Feb 1, 2024

We require contributors/corporates @begmaroman to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@cla-bot cla-bot bot removed the cla-signed label Feb 1, 2024
Copy link

cla-bot bot commented Feb 1, 2024

We require contributors/corporates @begmaroman to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

Copy link

cla-bot bot commented Feb 1, 2024

We require contributors/corporates @begmaroman to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@cla-bot cla-bot bot added the cla-signed label Feb 2, 2024
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@invocamanman invocamanman merged commit 96c0b72 into develop Feb 7, 2024
3 of 4 checks passed
@begmaroman begmaroman deleted the feature/CDK-45 branch February 13, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants